From 35963eb7a70227065744841f992f60e4b3ce0dc2 Mon Sep 17 00:00:00 2001
From: "Alex (Yowie IT MSP)" <alex@yowieit.com>
Date: Sat, 2 May 2026 22:15:00 +1000
Subject: [PATCH] ci: LLVM 16 via portable tar.xz (NSIS /S fails silently on
 unprivileged runner)

---
 .gitea/workflows/build.yml | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/.gitea/workflows/build.yml b/.gitea/workflows/build.yml
index 9a037a716..67014cd68 100644
--- a/.gitea/workflows/build.yml
+++ b/.gitea/workflows/build.yml
@@ -36,18 +36,32 @@ jobs:
           & "$env:CARGO_BIN\rustc.exe" --version
           & "$env:CARGO_BIN\cargo.exe" --version
 
-      - name: Setup LLVM 16 (matches upstream rustdesk CI)
+      - name: Setup LLVM 16 (portable tar.xz, no admin/UAC)
         shell: powershell
         run: |
           if (-not (Test-Path 'C:\LLVM16\bin\libclang.dll')) {
-            $url = "https://github.com/llvm/llvm-project/releases/download/llvmorg-$env:LLVM_VERSION/LLVM-$env:LLVM_VERSION-win64.exe"
-            $dst = "$env:TEMP\llvm-$env:LLVM_VERSION.exe"
+            # Portable tar.xz instead of NSIS installer — NSIS /S silently
+            # fails on unprivileged runners (some files missing post-install,
+            # caught run #4: "LLVM 16 install failed" after Start-Process -Wait
+            # returned 0). Extract via Windows 10/11 built-in tar.exe.
+            $url = "https://github.com/llvm/llvm-project/releases/download/llvmorg-$env:LLVM_VERSION/clang+llvm-$env:LLVM_VERSION-x86_64-pc-windows-msvc.tar.xz"
+            $dst = "$env:TEMP\llvm-$env:LLVM_VERSION.tar.xz"
             Write-Output "downloading $url"
             Invoke-WebRequest -Uri $url -OutFile $dst -UseBasicParsing -TimeoutSec 600
-            Write-Output "installing to C:\LLVM16"
-            Start-Process -FilePath $dst -ArgumentList '/S','/D=C:\LLVM16' -Wait
-            if (-not (Test-Path 'C:\LLVM16\bin\libclang.dll')) { throw "LLVM 16 install failed" }
+            $size = (Get-Item $dst).Length
+            Write-Output "downloaded $([math]::Round($size/1MB,2)) MB; extracting"
+            New-Item -ItemType Directory -Path 'C:\LLVM16-tmp' -Force | Out-Null
+            & tar.exe -xf $dst -C 'C:\LLVM16-tmp'
+            $extracted = Get-ChildItem 'C:\LLVM16-tmp' -Directory | Select-Object -First 1
+            Move-Item $extracted.FullName 'C:\LLVM16' -Force
+            Remove-Item 'C:\LLVM16-tmp' -Recurse -Force -ErrorAction SilentlyContinue
+            Remove-Item $dst -Force -ErrorAction SilentlyContinue
+            if (-not (Test-Path 'C:\LLVM16\bin\libclang.dll')) {
+              Get-ChildItem 'C:\LLVM16' -Recurse -Filter libclang.dll | Select-Object FullName
+              throw "LLVM 16 extract failed — libclang.dll not found"
+            }
           }
+          Write-Output "libclang.dll: $((Get-Item 'C:\LLVM16\bin\libclang.dll').Length) bytes"
           echo "LIBCLANG_PATH=C:\LLVM16\bin" >> $env:GITHUB_ENV
           echo "C:\LLVM16\bin" >> $env:GITHUB_PATH